Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump compat CategoricalArrays = "0.9, 0.10"; level -> levelcode #544

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Apr 30, 2021

Replaces #543

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #544 (f9d0782) into dev (8bd6034) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #544   +/-   ##
=======================================
  Coverage   84.87%   84.87%           
=======================================
  Files          36       36           
  Lines        3034     3034           
=======================================
  Hits         2575     2575           
  Misses        459      459           
Impacted Files Coverage Δ
src/interface/data_utils.jl 94.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd6034...f9d0782. Read the comment docs.

@ablaom
Copy link
Member Author

ablaom commented Apr 30, 2021

cc @nalimilan

@ablaom ablaom merged commit b11a919 into dev Apr 30, 2021
@ablaom ablaom mentioned this pull request Apr 30, 2021
@@ -28,7 +28,7 @@ StatsBase = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91"
Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"

[compat]
CategoricalArrays = "0.8.1, 0.9"
CategoricalArrays = "0.9, 0.10"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refcode doesn't exist on 0.9 IIRC. Maybe I can backport it if that's useful, though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops.

Yes, be great if you can back port to 0.9!

@DilumAluthge DilumAluthge deleted the categorical-arrays-0-point-eleven branch January 23, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants